Skip to content

fix: shape and size of the estia detector #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 23, 2025
Merged

fix: shape and size of the estia detector #162

merged 6 commits into from
May 23, 2025

Conversation

jokasimr
Copy link
Contributor

The shape and size of the detector was off

@jokasimr jokasimr requested a review from paracini May 21, 2025 15:03
jl-wynen
jl-wynen reviewed May 22, 2025
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also reshape when loading from NeXus? That way we check that the sizes are compatible with ECDC's data.

@jokasimr
Copy link
Contributor Author

It's currently not possible to load nexus files from coda because those have 126505 (with divisors 5 and 25301) detector_numbers which does not fit the shape we expect for the multiblade detector.

Not sure if the issue is that the shape we expect is wrong, or the numbers in the files are wrong.

@jokasimr
Copy link
Contributor Author

For the first 28201 rows of the detector dataset x_pixel_offset=y_pixel_offset=z_pixel_offset=-999.
Ignoring those rows 126505 - 28201 = 48 * 32 * 64 makes the detector have the expected shape.

jl-wynen
jl-wynen approved these changes May 23, 2025
View reviewed changes
Copy link
Member

@jl-wynen jl-wynen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Did you check with @paracini about the sizes?

@jokasimr
Copy link
Contributor Author

Yes it was he who noticed they were incorrect

@jokasimr jokasimr merged commit 907128b into main May 23, 2025
4 checks passed
@jokasimr jokasimr deleted the fix-estia-detector branch May 23, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jl-wynen jl-wynen jl-wynen approved these changes

@paracini paracini Awaiting requested review from paracini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jokasimr @jl-wynen